Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23304519
--- Diff: lib/cpp/src/thrift/protocol/TProtocol.h ---
@@ -659,6 +659,11 @@ class TProtocolFactory {
virtual ~TProtocolFactory() {}
virtual boost::shared_ptr<TProtocol>
getProtocol(boost::shared_ptr<TTransport> trans) = 0;
+ virtual boost::shared_ptr<TProtocol>
getProtocol(boost::shared_ptr<TTransport> inTrans,
--- End diff --
I'm not sure why this getProtocol overload is here. All the servers have
an inputProtocolFactory and outputProtocolFactory. Maybe this is a little bit
more usable... but it adds unusual noise to the review. I would like to have
some justification for this overload in regards to THeader... or I would like
to see this pulled into its own issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
