Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/357#discussion_r23308416
--- Diff: lib/cpp/src/thrift/protocol/TProtocol.h ---
@@ -659,6 +659,11 @@ class TProtocolFactory {
virtual ~TProtocolFactory() {}
virtual boost::shared_ptr<TProtocol>
getProtocol(boost::shared_ptr<TTransport> trans) = 0;
+ virtual boost::shared_ptr<TProtocol>
getProtocol(boost::shared_ptr<TTransport> inTrans,
--- End diff --
This makes sense. I would like that information captured in a comment
somewhere. Maybe in THeaderTransport.h?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
