[
https://issues.apache.org/jira/browse/THRIFT-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304031#comment-14304031
]
Konrad Grochowski commented on THRIFT-2724:
-------------------------------------------
All changes should be available in my branch:
https://github.com/hcorg/thrift/tree/coding_standards
I've never had time to finish C++ coding standards, maybe if it's get public
I'll finally force myself to do it ;)
I can rebase branch and merge it, making it a good starting point for future
contributions (I was hoping to complete all subtasks before merging, but I
can't provide standards for langs I'm not actively using, so making it public
and waiting for feedback might be a better idea).
As for linters etc: "make style" already works (I'm pretty sure it was merged
to master on some point) - as it introduces some new dependencies it is not
merged with 'make check', but it runs clang-format on C++ code and codespell on
whole repo. clang-format could be also configured to work with JS code
> Coding standards page
> ---------------------
>
> Key: THRIFT-2724
> URL: https://issues.apache.org/jira/browse/THRIFT-2724
> Project: Thrift
> Issue Type: Improvement
> Components: Documentation
> Reporter: Konrad Grochowski
> Attachments: coding_standards.patch
>
>
> it would be nice to have some basic coding standards for all langs used by
> thrift, especially those that do not come with 'built-in' standards.
> I'm suggesting some simple, short guidelines, just to help contributors
> prepare good patch
> preferably: new doc in docs folder, linked from doc/contributing.md
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
