[
https://issues.apache.org/jira/browse/THRIFT-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392709#comment-14392709
]
ASF GitHub Bot commented on THRIFT-1025:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/416
[THRIFT-1025] allow TSSLServerSocket and TServerSocket to optionally bin...
...d to a specific interface
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT-1025-TServerSocket-bind-to-interface
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit 388b5bca17159438366fd1b8c7f2cb3a57607b05
Author: Jim King <[email protected]>
Date: 2015-04-02T13:41:56Z
[THRIFT-1025] allow TSSLServerSocket and TServerSocket to optionally bind
to a specific interface
----
> C++ ServerSocket should inherit from Socket with the necessary Ctor to listen
> on connections from a specific host (similar to perl library)
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1025
> URL: https://issues.apache.org/jira/browse/THRIFT-1025
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Environment: any
> Reporter: Valery Kreidenko
> Assignee: Ben Craig
> Attachments: THRIFT-1025.patch
>
>
> Perl library ServerSocket inherits from Socket the ctor ServerSocket->new(
> addr, port) which enables to accept the connections from specified host only
> (for security reasons for instance).
> package Thrift::ServerSocket;
> use Socket qw(IPPROTO_TCP TCP_NODELAY);
> use base qw( Thrift::Socket Thrift::ServerTransport );
> while surprisingly C++ ServerSocket omits inheriting from Socket.
> class TServerSocket : public TServerTransport {
> Regards.
> Valery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
