[ 
https://issues.apache.org/jira/browse/THRIFT-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395760#comment-14395760
 ] 

Hudson commented on THRIFT-1025:
--------------------------------

SUCCESS: Integrated in Thrift #1491 (See 
[https://builds.apache.org/job/Thrift/1491/])
THRIFT-1025 C++ ServerSocket should inherit from Socket with the necessary Ctor 
to listen on connections from a specific host (similar to perl library) (roger: 
rev 011445528fc779c27e8755c0af4ea5dff8c1005d)
* lib/cpp/src/thrift/transport/TSSLServerSocket.cpp
* lib/cpp/src/thrift/transport/TServerSocket.cpp
* lib/cpp/src/thrift/transport/TSSLServerSocket.h
* lib/cpp/test/TServerSocketTest.cpp
* lib/cpp/src/thrift/transport/TServerSocket.h
* lib/cpp/test/TestPortFixture.h
* lib/cpp/test/Makefile.am
THRIFT-1025 C++ ServerSocket should inherit from Socket with the necessary Ctor 
to listen on connections from a specific host (similar to perl library) (roger: 
rev 3815e0b2dcd63ebfe245dcc41022c64a898bd667)
* lib/cpp/test/CMakeLists.txt


> C++ ServerSocket should inherit from Socket with the necessary Ctor to listen 
> on connections from a specific host (similar to perl library)
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1025
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1025
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>         Environment: any
>            Reporter: Valery Kreidenko
>            Assignee: Ben Craig
>         Attachments: THRIFT-1025.patch
>
>
> Perl library ServerSocket inherits from Socket  the ctor ServerSocket->new( 
> addr, port) which enables to accept the connections from specified host only 
> (for security reasons for instance).
> package  Thrift::ServerSocket;
> use Socket qw(IPPROTO_TCP TCP_NODELAY);
> use base qw( Thrift::Socket Thrift::ServerTransport );
> while surprisingly C++ ServerSocket omits inheriting from Socket.
> class TServerSocket : public TServerTransport {
> Regards.
> Valery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to