[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394851#comment-14394851
]
James E. King, III commented on THRIFT-2441:
--------------------------------------------
I rewrote peek to use THRIFT_POLL instead of recv(MSG_PEEK) so it can
optionally interrupt based on the work we've discussed. Given this is the hot
path for reads, I'm going to try an experiment at some point and get rid of
peek all together to see if things "just work". I suspect peek was put there
to deal with incorrect disconnect handling or some other bug in the code, and
it got left there. This will end up as part of THRIFT-3081.
> Cannot shutdown TThreadedServer when clients are still connected
> ----------------------------------------------------------------
>
> Key: THRIFT-2441
> URL: https://issues.apache.org/jira/browse/THRIFT-2441
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Reporter: Chris Stylianou
> Assignee: Ben Craig
> Attachments: THRIFT-2441-prelim.patch
>
>
> When calling stop() on the TThreadedServer no interrupts are sent to the
> client threads. This means the stop() call blocks on tasksMonitor.wait()
> until all client naturally disconnect.
> How can we tell the client thread connections to close/exit during the
> TThreadedServer::stop() call?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
