[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490578#comment-14490578
]
ASF GitHub Bot commented on THRIFT-2441:
----------------------------------------
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/424#discussion_r28189195
--- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp ---
@@ -88,7 +88,7 @@ void TSimpleServer::serve() {
string errStr = string("Some kind of accept exception: ") +
tx.what();
GlobalOutput(errStr.c_str());
continue;
- } catch (string s) {
+ } catch (const string& s) {
--- End diff --
I don't know of any code in thrift that intentionally throws a string.
Throwing a string (or anything without a vtable really) is certainly a poor
practice.
> Cannot shutdown TThreadedServer when clients are still connected
> ----------------------------------------------------------------
>
> Key: THRIFT-2441
> URL: https://issues.apache.org/jira/browse/THRIFT-2441
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Reporter: Chris Stylianou
> Assignee: Ben Craig
> Attachments: THRIFT-2441-prelim.patch
>
>
> When calling stop() on the TThreadedServer no interrupts are sent to the
> client threads. This means the stop() call blocks on tasksMonitor.wait()
> until all client naturally disconnect.
> How can we tell the client thread connections to close/exit during the
> TThreadedServer::stop() call?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
