[
https://issues.apache.org/jira/browse/THRIFT-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395892#comment-14395892
]
James E. King, III commented on THRIFT-1025:
--------------------------------------------
Thanks for taking care of the CMakeLists.txt file change. I will ensure both
cmake and regular builds work properly in future check-ins.
> C++ ServerSocket should inherit from Socket with the necessary Ctor to listen
> on connections from a specific host (similar to perl library)
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1025
> URL: https://issues.apache.org/jira/browse/THRIFT-1025
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Environment: any
> Reporter: Valery Kreidenko
> Assignee: Roger Meier
> Attachments: THRIFT-1025.patch
>
>
> Perl library ServerSocket inherits from Socket the ctor ServerSocket->new(
> addr, port) which enables to accept the connections from specified host only
> (for security reasons for instance).
> package Thrift::ServerSocket;
> use Socket qw(IPPROTO_TCP TCP_NODELAY);
> use base qw( Thrift::Socket Thrift::ServerTransport );
> while surprisingly C++ ServerSocket omits inheriting from Socket.
> class TServerSocket : public TServerTransport {
> Regards.
> Valery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
