[ https://issues.apache.org/jira/browse/THRIFT-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482236#comment-14482236 ]
Ben Craig commented on THRIFT-3084: ----------------------------------- I'm great with gutting TThreadedServer, but I don't want to remove it. That is breaking source compatibility without a great reason. Perhaps make TThreadedServer such that it is implemented entirely in terms of TThreadPoolServer (i.e. TThreadedServer methods forward to an embedded TThreadPoolServer member). Or make a typedef alias that is still source compatible. I'd rather not break source compatibility though. > C++ add concurrent client limit to threaded servers > --------------------------------------------------- > > Key: THRIFT-3084 > URL: https://issues.apache.org/jira/browse/THRIFT-3084 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.8, 0.9, 0.9.1, 0.9.2 > Reporter: James E. King, III > > The TThreadedServer and TThreadPoolServer do not impose limits on the number > of simultaneous connections, which is not useful in production as bad clients > can drive a server to consume too many file descriptors or have too many > threads. > 1. Add a barrier to TServerTransport that will be checked before accept(). > 2. In the onClientConnected override (see THRIFT-3083) if the server reaches > the limit of the number of accepted clients, enable the barrier. > 3. In the onClientDisconnected override if the count of connected clients > falls below the maximum concurrent limit, clear the barrier. This will allow > the limit to be changed dynamically at runtime (lowered) with drain off > clients until more can be accepted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)