[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484537#comment-14484537
]
Xiaoshuang LU commented on THRIFT-3013:
---------------------------------------
Hi Roger, I share your opinion. But I am afraid I do not think it is a good
idea to reject this patch. Here are some reasons.
1. Official documentation (http://thrift.apache.org/docs/install/) guides users
to build thrift from scratch with Cygwin/MinGW in Microsoft Windows. I suppose
that "getopt_long" is not a obstacle since both Cygwin and MinGW offer users
such function.
2. I have already borrowed "getopt_long" from FreeBSD repository, although it
was not included in this patch. If possible, I would be glad to submit
"getopt_long" in another JIRA ticket.
By the way, there is a obvious unportable code block in
compiler/cpp/src/main.cc. Line 37 and line 38 include "sys/types.h" and
"sys/stat.h" respectively, but these header files are introduced in POSIX.
> make thrift compiler accept a list of input files
> -------------------------------------------------
>
> Key: THRIFT-3013
> URL: https://issues.apache.org/jira/browse/THRIFT-3013
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Affects Versions: 0.9.2
> Reporter: Xiaoshuang LU
> Assignee: Roger Meier
> Attachments: THRIFT-3013.patch
>
>
> At present, customer could specify one input file to the thrift compiler.
> There are maybe two approaches to support multiple input files.
> Approach 1: Improve the option parser in compiler/cpp/src/main.cc. Maybe we
> can borrow code from GUN's getopt_long.
> Approach 2: Offer uses a maven plugin which can help them to iterate through
> a list of input files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
