[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487595#comment-14487595
]
James E. King, III commented on THRIFT-3013:
--------------------------------------------
I see no reason to shy away from using boost::program_options simply because it
is C++, nor would I classify it as more difficult or more simple. I would
suggest that leveraging boost::program_options gives you cross-platform code
that is well tested and regularly patched and revised by external entities,
whereas pulling in third party code directly into the project like this forces
the responsibility of keeping the third party code updated to the project
incorporating it. Regardless, a solution that builds on all platforms is the
requirement, not how options are processed, and others who have been more
active in the project longer can discuss the merits of directly including third
party code.
I'd recommend adding a unit or integration test as part of your patch to test
all the positive and negative command options including the new ability to
specify multiple input files, since it looks like the options processing code
paths have changed completely, and to make sure your changes allow it to be
built in both the "configure" build environment as well as the "CMake" build
environment.
> make thrift compiler accept a list of input files
> -------------------------------------------------
>
> Key: THRIFT-3013
> URL: https://issues.apache.org/jira/browse/THRIFT-3013
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Affects Versions: 0.9.2
> Reporter: Xiaoshuang LU
> Assignee: Roger Meier
> Attachments: THRIFT-3013.patch, THRIFT-3013.v2.patch
>
>
> At present, customer could specify one input file to the thrift compiler.
> There are maybe two approaches to support multiple input files.
> Approach 1: Improve the option parser in compiler/cpp/src/main.cc. Maybe we
> can borrow code from GUN's getopt_long.
> Approach 2: Offer uses a maven plugin which can help them to iterate through
> a list of input files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
