[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491417#comment-14491417 ]
ASF GitHub Bot commented on THRIFT-2441: ---------------------------------------- GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/424 THRIFT-2441 prevent client connections from delaying server stop You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift bugfix/THRIFT-2441-disconnect-clients-on-server-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #424 ---- commit 4113f4f50bc4a6a1488b56db14a15e96527c44a7 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-04T19:26:54Z [THRIFT-2441] prevent client connections from delaying server stop commit 730877b51d6ef96f84cad34e055f01fd9503aa96 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-04T23:09:16Z [THRIFT-2441] fix stop handling of simple, threaded server commit ad68c576a75257dcca26b2c1b88fab27dcd967f0 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T04:10:37Z Merge branch 'master' of github.com:jeking3/thrift into bugfix/THRIFT-2441-disconnect-clients-on-server-stop commit 251d4d4a2edb3ee95f7b200c70333d7fdc8171c8 Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-10T04:44:10Z THRIFT-2441 addressed code review concerns commit 0ca766bfd4c8be98481c7295f1bec5e040959ffc Author: Jim King <jim.k...@simplivity.com> Date: 2015-04-12T10:42:21Z THRIFT-2441 added TServerIntegrationTest to prove combined behavior is correct; fixed TSocket handling of ECONNRESET ---- > Cannot shutdown TThreadedServer when clients are still connected > ---------------------------------------------------------------- > > Key: THRIFT-2441 > URL: https://issues.apache.org/jira/browse/THRIFT-2441 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9.1 > Reporter: Chris Stylianou > Assignee: Ben Craig > Attachments: THRIFT-2441-prelim.patch > > > When calling stop() on the TThreadedServer no interrupts are sent to the > client threads. This means the stop() call blocks on tasksMonitor.wait() > until all client naturally disconnect. > How can we tell the client thread connections to close/exit during the > TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)