[
https://issues.apache.org/jira/browse/THRIFT-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523203#comment-14523203
]
Jake Farrell commented on THRIFT-3105:
--------------------------------------
The release notes are generated from the tickets fix version, so does not
matter if they are resolved and someone bulk sets the fix version and closes or
if they are just closed with that all ready set.
The other thing to make sure of is that the person who has done the work on the
ticket is set as the asignee, that way the merit for the ticket can be recorded
and we can look it up easier later on (say when considering a new committer)
> C++ libthriftnb library on Windows build failure
> ------------------------------------------------
>
> Key: THRIFT-3105
> URL: https://issues.apache.org/jira/browse/THRIFT-3105
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Environment: Visual Studio 2010, Boost 1.53, OpenSSL 1.0.1b, libevent
> 2.0.22
> Reporter: James E. King, III
> Assignee: Konrad Grochowski
> Fix For: 0.9.3
>
>
> Attempted to build libthriftnb and got a build failure:
> {noformat}1>------ Build started: Project: libthriftnb, Configuration: Debug
> Win32 ------
> 1> TNonblockingServer.cpp
> 1>c:\users\jim\workspace\thrift\lib\cpp\src\thrift\server\tnonblockingserver.cpp(1110):
> error C2664: 'getsockname' : cannot convert parameter 3 from 'unsigned int
> *' to 'int *'
> 1> Types pointed to are unrelated; conversion requires
> reinterpret_cast, C-style cast or function-style cast
> 1> TEvhttpServer.cpp
> 1> TEvhttpClientChannel.cpp
> 1> Generating Code...
> ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
> {noformat}
> The type for the size should be changed to "socklen_t", it is declared as
> "unsigned int". TSocket uses this as well, and it works across platforms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
