[ 
https://issues.apache.org/jira/browse/THRIFT-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524502#comment-14524502
 ] 

Henrique Mendonça commented on THRIFT-3105:
-------------------------------------------

As Jens said, most users cannot be assigned and it seemed like the assignee 
field was been used as a synchronisation point so we'd now that someone is 
already reviewing/committing that patch. This works quite well IMHO.
Although it'd be just fair to assign it to the contributor, their activity also 
reflects on the email volume, as Jake had already used a couple of times.
An alternative would be to try to assign it again to the contributor before 
resolving it, or use another field for the committers...


> C++ libthriftnb library on Windows build failure
> ------------------------------------------------
>
>                 Key: THRIFT-3105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3105
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.2
>         Environment: Visual Studio 2010, Boost 1.53, OpenSSL 1.0.1b, libevent 
> 2.0.22
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>             Fix For: 0.9.3
>
>
> Attempted to build libthriftnb and got a build failure:
> {noformat}1>------ Build started: Project: libthriftnb, Configuration: Debug 
> Win32 ------
> 1>  TNonblockingServer.cpp
> 1>c:\users\jim\workspace\thrift\lib\cpp\src\thrift\server\tnonblockingserver.cpp(1110):
>  error C2664: 'getsockname' : cannot convert parameter 3 from 'unsigned int 
> *' to 'int *'
> 1>          Types pointed to are unrelated; conversion requires 
> reinterpret_cast, C-style cast or function-style cast
> 1>  TEvhttpServer.cpp
> 1>  TEvhttpClientChannel.cpp
> 1>  Generating Code...
> ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
> {noformat}
> The type for the size should be changed to "socklen_t", it is declared as 
> "unsigned int".  TSocket uses this as well, and it works across platforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to