[ 
https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545358#comment-14545358
 ] 

Konstantin Shaposhnikov commented on THRIFT-3131:
-------------------------------------------------

I am afraid that without HTTPS support from Apache my change request won't be 
accepted 

>From https://go-review.googlesource.com/#/c/10092/:

Brad Fitzpatrick
11:57 AM
↩
Patch Set 1:
If Apache doesn't do encryption, I don't think we should special case them. 
Doesn't seem like it meets the quality bar.



> Consolidate suggested import path for go thrift library to git.apache.org in 
> docs and code
> ------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3131
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3131
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler, Go - Library
>            Reporter: Konstantin Shaposhnikov
>            Assignee: Konstantin Shaposhnikov
>
> https://github.com/apache/thrift/blob/master/lib/go/README.md suggests to use 
> the following import path for go thrift library:
> git-wip-us.apache.org/repos/asf/thrift.git/lib/go/thrift
> However thrift compiler uses different import path in the generated files by 
> default:
> git.apache.org/thrift.git/lib/go/thrift 
> To avoid confusion it would be good to use a single import path both in the 
> generated code and in the user documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to