Github user jimspeth commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-120408184
I love it.
A couple of minor changes that will make the header files even more
readable:
* Remove the `getter=` and `setter=` from the property declarations, since
the format they use is the default already.
* Remove `- (instancetype) init;` from the generated interfaces, since
that's defined by NSObject.
* Remove `read:` and `write:` methods from the interfaces, since they are
declared by the `TBase` protocol.
* Move `validate:` to `TBase` protocol and remove from the interfaces.
Also, the `unset*` methods in the implementations are not used and not
exposed in the interface. They could be removed from the implementation. A
possible way to support unsetting values would be to have it generate overrides
for the `*IsSet` properties, like this:
```
- (void) setMyValueIsSet: (BOOL) isSet {
_myValueIsSet = isSet;
if (!isSet) {
_myValue = nil;
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
