Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/539#issuecomment-146446009
The biggest change is that simple types (bool, byte, etc) are now mapped
differently to allow the proper use of NSError. These types now map to NSNumber
instead. Aside from using NSError parameters that is the only material change.
e.g. this
NSError *error;
NSNumber *byte = client.testByte(&error);
UInt8 actualByte = byte.unsignedCharValue
if (!byte) {
//handle error
}
instead of...
@try {
UInt8 byte = client.testByte()
}
@catch(NSException *x) {
//handle error
}
Please understand that the current method (NSException) is severely
deprecated and has been for years; even without Swift compatibility these
changes should be made. The mapping changes I enacted are necessary to use the
proper NSError based method.
> On Oct 8, 2015, at 12:10 AM, Jens Geyer <[email protected]> wrote:
>
> What about the compat breaks?
> ________________________________
> Von: Kevin Wooten
> Gesendet: 07.10.2015 22:11
> An: apache/thrift
> Cc: Jens Geyer
> Betreff: Re: [thrift] Thrift 2905 & - Modern Objective-C & Swift Support
(#539)
>
> @Jens-G The entirety of the Objective-C changes are "complete" as far as
I am concerned. We have been using them successfully for quite a while.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/thrift/pull/539#issuecomment-146314451
> â
> Reply to this email directly or view it on GitHub
<https://github.com/apache/thrift/pull/539#issuecomment-146440075>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
