[ https://issues.apache.org/jira/browse/THRIFT-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902300#comment-14902300 ]
ASF GitHub Bot commented on THRIFT-3345: ---------------------------------------- GitHub user huahang opened a pull request: https://github.com/apache/thrift/pull/618 THRIFT-3345: Clients blocked indefinitely when an Error is thrown https://issues.apache.org/jira/browse/THRIFT-3345 You can merge this pull request into a Git repository by running: $ git pull https://github.com/huahang/thrift patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/618.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #618 ---- commit 8d5f8ee93c6918fbd870c54e393d114c9e67b082 Author: huahang <huah...@users.noreply.github.com> Date: 2015-09-22T09:40:26Z THRIFT-3345: Clients blocked indefinitely when a java.lang.Error is thrown https://issues.apache.org/jira/browse/THRIFT-3345 ---- > Clients blocked indefinitely when a java.lang.Error is thrown > ------------------------------------------------------------- > > Key: THRIFT-3345 > URL: https://issues.apache.org/jira/browse/THRIFT-3345 > Project: Thrift > Issue Type: Bug > Components: Java - Library > Affects Versions: 0.5, 0.9.1, 0.9.2 > Reporter: Huahang Liu > Priority: Critical > > When a java.lang.Exception is thrown in a thrift server method, client > connections get closed properly. Please see the clean up code below. > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L300 > But if a java.lang.Error is thrown, that block of clean up code won't be > executed and thus client connections may block indefinitely. I think the > clean up code show be move to a finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)