[ https://issues.apache.org/jira/browse/THRIFT-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905399#comment-14905399 ]
Hudson commented on THRIFT-3345: -------------------------------- SUCCESS: Integrated in Thrift #1662 (See [https://builds.apache.org/job/Thrift/1662/]) THRIFT-3345 Clients blocked indefinitely when a java.lang.Error is thrown (jensg: rev b121a586b20c801bb52aa423b2d0edddf5d3ce9e) * lib/java/src/org/apache/thrift/server/TThreadPoolServer.java > Clients blocked indefinitely when a java.lang.Error is thrown > ------------------------------------------------------------- > > Key: THRIFT-3345 > URL: https://issues.apache.org/jira/browse/THRIFT-3345 > Project: Thrift > Issue Type: Bug > Components: Java - Library > Affects Versions: 0.5, 0.9.1, 0.9.2 > Reporter: Huahang Liu > Assignee: Huahang Liu > Priority: Critical > Fix For: 0.9.3 > > > When a java.lang.Exception is thrown in a thrift server method, client > connections get closed properly. Please see the clean up code below. > https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L300 > But if a java.lang.Error is thrown, that block of clean up code won't be > executed and thus client connections may block indefinitely. I think the > clean up code should be move to a finally block. > A pull request has been sent to Github: > https://github.com/apache/thrift/pull/618 -- This message was sent by Atlassian JIRA (v6.3.4#6332)