[
https://issues.apache.org/jira/browse/THRIFT-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904114#comment-14904114
]
ASF GitHub Bot commented on THRIFT-3329:
----------------------------------------
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/620#discussion_r40177295
--- Diff: lib/cpp/test/SecurityTest.cpp ---
@@ -75,13 +75,17 @@ struct GlobalFixture
if (!boost::filesystem::exists(certFile("server.crt")))
{
keyDir =
boost::filesystem::path(master_test_suite().argv[master_test_suite().argc - 1]);
-
BOOST_REQUIRE_MESSAGE(boost::filesystem::exists(certFile("server.crt")),
- "The last argument to this test must
be the directory containing the test certificate(s).");
+ if (!boost::filesystem::exists(certFile("server.crt")))
+ {
+ std::cerr << "The last argument to this test must be
the directory containing the test certificate(s)." << std::endl;
--- End diff --
damn, I was using "let's do some checks in fixture constructor" method
quite offten... ok, another idea (cleaner than exit(1)) - just throw
std::runtime_error with message. Boost has to deal with exceptions, this could
make better error info etc.
> C++ library unit tests don't compile against the new boost-1.59 unit test
> framework
> -----------------------------------------------------------------------------------
>
> Key: THRIFT-3329
> URL: https://issues.apache.org/jira/browse/THRIFT-3329
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Critical
>
> BOOST_MESSAGE was deprecated in the past and has finally been removed (tried
> boost-1.59, possibly removed in an earlier release, but it all works in
> boost-1.54). Some of the C++ library unit test code uses BOOST_MESSAGE so it
> won't compile any more. In addition, the method to make a test has changed
> slightly and needs version specific code to handle both old and new.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
