[ 
https://issues.apache.org/jira/browse/THRIFT-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908525#comment-14908525
 ] 

ASF GitHub Bot commented on THRIFT-3329:
----------------------------------------

Github user hcorg commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/620#discussion_r40464192
  
    --- Diff: lib/cpp/test/TransportTest.cpp ---
    @@ -1016,7 +1019,7 @@ struct global_fixture {
       }
     };
     
    -BOOST_GLOBAL_FIXTURE(global_fixture)
    +BOOST_GLOBAL_FIXTURE(global_fixture);
    --- End diff --
    
    blah.... so another ifdef :) (I just hate warnings...)


> C++ library unit tests don't compile against the new boost-1.59 unit test 
> framework
> -----------------------------------------------------------------------------------
>
>                 Key: THRIFT-3329
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3329
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.3
>            Reporter: James E. King, III
>            Assignee: Konrad Grochowski
>
> BOOST_MESSAGE was deprecated in the past and has finally been removed (tried 
> boost-1.59, possibly removed in an earlier release, but it all works in 
> boost-1.54).  Some of the C++ library unit test code uses BOOST_MESSAGE so it 
> won't compile any more.  In addition, the method to make a test has changed 
> slightly and needs version specific code to handle both old and new.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to