[
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909786#comment-14909786
]
ASF GitHub Bot commented on THRIFT-3357:
----------------------------------------
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/627#discussion_r40506016
--- Diff: compiler/cpp/src/generate/t_java_generator.cc ---
@@ -5139,8 +5215,11 @@ THRIFT_REGISTER_GENERATOR(
" reuse-objects: Data objects will not be allocated, but existing
instances will be used "
"(read and write).\n"
" sorted_containers:\n"
- " Use TreeSet/TreeMap instead of HashSet/HashMap
as a implementation of "
+ " Use TreeSet/TreeMap instead of HashSet/HashMap
as an implementation of "
"set/map.\n"
+ " enum_containers:\n"
--- End diff --
Not so sure if we need a new option at all. The default assumptions for
Thrift containers are described at https://thrift.apache.org/docs/types . If
the patch does not break compatibility and on top is more efficient, why not
make it the default? $0,02
> Additional java compiler option to generate EnumSet/EnumMap where
> elements/keys are enums
> -----------------------------------------------------------------------------------------
>
> Key: THRIFT-3357
> URL: https://issues.apache.org/jira/browse/THRIFT-3357
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler
> Reporter: Deniss Afonin
>
> Additional java compiler option to generate EnumSet/EnumMap instead of
> HashSet/HashMap where elements/keys are enums.
> This makes these maps/sets memory efficient and faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
