[
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909863#comment-14909863
]
ASF GitHub Bot commented on THRIFT-3357:
----------------------------------------
Github user afds commented on the pull request:
https://github.com/apache/thrift/pull/627#issuecomment-143589859
I'm perfectly fine to make it default.
Theoretically possible issues is that someone heavily relies on
HashMap/HashSet or uses _null_ keys/elements (EnumMap/EnumSet does not allow
_null_ keys/elements). But in that case, we indeed, need to make it default to
punish them.
> Additional java compiler option to generate EnumSet/EnumMap where
> elements/keys are enums
> -----------------------------------------------------------------------------------------
>
> Key: THRIFT-3357
> URL: https://issues.apache.org/jira/browse/THRIFT-3357
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler
> Reporter: Deniss Afonin
>
> Additional java compiler option to generate EnumSet/EnumMap instead of
> HashSet/HashMap where elements/keys are enums.
> This makes these maps/sets memory efficient and faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
