[
https://issues.apache.org/jira/browse/THRIFT-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957611#comment-14957611
]
ASF GitHub Bot commented on THRIFT-3382:
----------------------------------------
GitHub user beberg opened a pull request:
https://github.com/apache/thrift/pull/653
THRIFT-3382 TBase class for C++ Library
Add a TBase that all Struct's use as their base class.
Contributed by Sentient Technologies - http://www.sentient.ai/
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/beberg/thrift THRIFT-3382-TBase-for-cpp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/653.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #653
----
commit cc9002a82229cc680a21c8f749a5a21dc2e4e760
Author: Adam Beberg <beb...@sentient.ai>
Date: 2015-09-23T21:50:01Z
Support for database/sql - Scan(), Value(), and db: tags
Contributed by Sentient Technologies - http://www.sentient.ai/
commit 713230d6b8ebdbbb6f7e9991b7f932fa4138e03e
Author: Adam Beberg <beb...@mithral.com>
Date: 2015-09-25T18:45:45Z
Merge pull request #1 from beberg/THRIFT-3339-Go-Support-for-Databases
Support for database/sql - Scan(), Value(), and db: tags
commit 61010d66c38dc0b086e8aedc13f424eaf6d75aeb
Author: Adam Beberg <beb...@sentient.ai>
Date: 2015-09-26T01:18:56Z
Fix error message text
commit d9534313798e03656db7eb407b3332a89ca2cb0e
Author: Adam Beberg <beb...@mithral.com>
Date: 2015-09-26T01:20:23Z
Merge pull request #2 from beberg/THRIFT-3339-Go-Support-for-Databases
Fix error message text
commit 4d6288dfa681d33020ffa40ed675b2fc68f393aa
Author: Adam Beberg <beb...@sentient.ai>
Date: 2015-09-23T21:50:01Z
Support for database/sql - Scan(), Value(), and db: tags
Contributed by Sentient Technologies - http://www.sentient.ai/
commit a671c0097dfd04c58563c2075c474aec2b134f35
Author: Adam Beberg <beb...@sentient.ai>
Date: 2015-09-26T01:18:56Z
Fix error message text
commit 474331f4e845e65927879af4f8b8c05680333911
Author: Adam Beberg <beb...@sentient.ai>
Date: 2015-10-14T17:31:20Z
Merge branch 'master' of https://github.com/beberg/thrift
commit 669a583cc360528d922d7f395a13448c836a3786
Author: Adam Beberg <beb...@sentient.ai>
Date: 2015-10-14T18:37:39Z
THRIFT-3382 TBase class for C++ Library
Add a TBase that all Struct's use as their base class.
Contributed by Sentient Technologies - http://www.sentient.ai/
----
> TBase class for C++ Library
> ---------------------------
>
> Key: THRIFT-3382
> URL: https://issues.apache.org/jira/browse/THRIFT-3382
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.9.3
> Reporter: Adam Beberg
> Assignee: Adam Beberg
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Unlike Other languages, C++ is missing a TBase class (the majority of other
> langugaes call it that) that all generated structs always inherit from. This
> prevents simple utility functions, and forces ugly template use.
> Something like this:
> {code:title=thtift/TBase.h}
> class TBase {
> public:
> virtual ~TBase();
> virtual uint32_t read(::apache::thrift::protocol::TProtocol* iprot);
> virtual uint32_t write(::apache::thrift::protocol::TProtocol* oprot) const;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
