[ 
https://issues.apache.org/jira/browse/THRIFT-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957899#comment-14957899
 ] 

Roger Meier commented on THRIFT-3382:
-------------------------------------

[~beberg] please do not add some ad's to the commit message, you can use your 
companies mail address to commit or add a Sponsored-By similar to a [Tested-by 
| https://www.kernel.org/doc/Documentation/SubmittingPatches] tag if the commit 
is done by another person on behalf of your company. We can add your company to 
http://thrift.apache.org/about , just tell us.

> TBase class for C++ Library
> ---------------------------
>
>                 Key: THRIFT-3382
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3382
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.9.3
>            Reporter: Adam Beberg
>            Assignee: Adam Beberg
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Unlike Other languages, C++ is missing a TBase class (the majority of other 
> langugaes call it that) that all generated structs always inherit from. This 
> prevents simple utility functions, and forces ugly template use.
> Something like this:
> {code:title=thtift/TBase.h}
> class TBase {
> public:
>   virtual ~TBase();
>   virtual uint32_t read(::apache::thrift::protocol::TProtocol* iprot);
>   virtual uint32_t write(::apache::thrift::protocol::TProtocol* oprot) const;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to