[ https://issues.apache.org/jira/browse/THRIFT-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964575#comment-14964575 ]
ASF GitHub Bot commented on THRIFT-3395: ---------------------------------------- GitHub user skeeet opened a pull request: https://github.com/apache/thrift/pull/657 Cocoa compiler: fixed incorrect boxing of enums inside map. #THRIFT-3395 You can merge this pull request into a Git repository by running: $ git pull https://github.com/skeeet/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/657.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #657 ---- commit 33bc16aef4ec3fc954bfa5e4b84f198faa22012a Author: Aleksei Shevchenko <aleksei.shevche...@bluechipsys.com> Date: 2015-10-20T05:50:21Z Cocoa compiler: fixed incorrect boxing of enums inside map. #THRIFT-3395 ---- > Cocoa compiler produces corrupt code when boxing enums inside map. > ------------------------------------------------------------------ > > Key: THRIFT-3395 > URL: https://issues.apache.org/jira/browse/THRIFT-3395 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Compiler > Reporter: Aleksei Shevchenko > Fix For: 1.0 > > > Essentially fix for https://issues.apache.org/jira/browse/THRIFT-2905 and PR > #652. > Given something like this: > {code} > void someRpcCall(1:map<SomeEnum, AnotherEnum> param); > {code} > Cocoa compiler produces corrupt implementation. > {code} > - (BOOL) someRpcCall:(NSDictionary< , > *) param error: (NSError > *__autoreleasing *)__thriftError; > {code} > This fixes it so code rendered properly, boxing enums into NSNumber*. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)