[ 
https://issues.apache.org/jira/browse/THRIFT-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973277#comment-14973277
 ] 

ASF GitHub Bot commented on THRIFT-3395:
----------------------------------------

Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/657#issuecomment-150932151
  
    Merged, can be closed.


> Cocoa compiler produces corrupt code when boxing enums inside map.
> ------------------------------------------------------------------
>
>                 Key: THRIFT-3395
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3395
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Compiler
>            Reporter: Aleksei Shevchenko
>            Assignee: Aleksei Shevchenko
>             Fix For: 1.0
>
>
> Essentially fix for https://issues.apache.org/jira/browse/THRIFT-2905 and PR 
> #652.
> Given something like this:
> {code}
> void someRpcCall(1:map<SomeEnum, AnotherEnum> param);
> {code}
> Cocoa compiler produces corrupt implementation.
> {code}
> - (BOOL) someRpcCall:(NSDictionary< , > *) param error: (NSError 
> *__autoreleasing *)__thriftError;
> {code}
> This fixes it so code rendered properly, boxing enums into NSNumber*.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to