Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42542828
--- Diff: compiler/cpp/src/thriftl.ll ---
@@ -155,7 +155,8 @@ literal_begin (['\"])
"include" { return tok_include; }
"void" { return tok_void; }
"bool" { return tok_bool; }
-"byte" { return tok_byte; }
+"byte" { return tok_i8; }
--- End diff --
could we somehow generate warning here? "using byte type is deprecated as
it might lead to misunderstanding in signess" or something
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
