Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42542836
--- Diff: test/ThriftTest.thrift ---
@@ -86,7 +86,7 @@ struct Xtruct
struct Xtruct2
{
- 1: byte byte_thing,
+ 1: i8 byte_thing, // used to be byte, hence the name
--- End diff --
I'd go with full rename ;) (just my normal hate for comments :D)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
