[ https://issues.apache.org/jira/browse/THRIFT-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005459#comment-15005459 ]
ASF GitHub Bot commented on THRIFT-3416: ---------------------------------------- GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/700 THRIFT-3416 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-3416 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/700.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #700 ---- commit 9fdff7918a829c842caeb84a063ded38a0f2106b Author: Jens Geyer <je...@apache.org> Date: 2015-11-14T14:21:57Z THRIFT-3416 Retire old "xxx_namespace" declarations from the IDL Client: Compiler (general) Patch: Jens Geyer ---- > Retire old "xxx_namespace" declarations from the IDL > ---------------------------------------------------- > > Key: THRIFT-3416 > URL: https://issues.apache.org/jira/browse/THRIFT-3416 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) > Reporter: Jens Geyer > > While poking into the IDL syntax, I found that hidden gem: > {code} > | tok_xsd_namespace tok_literal > { > pwarning(1, "'xsd_namespace' is deprecated. Use 'namespace xsd' > instead"); > pdebug("Header -> tok_xsd_namespace tok_literal"); > declare_valid_program_doctext(); > if (g_parse_mode == PROGRAM) { > g_program->set_namespace("cocoa", $2); // what ... COCOA ?!? > } > } > {code} > While thinking whether I should do sth about it, I came to the conclusion > that the time ist right to "_Get rid of this_" since today probably really > "_everyone is using the new hotness_", as the comments say. > Opinions? > If there are no objections, I'll provide a patch to convert the warnings into > an error and remove the rest of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)