Github user henrique commented on a diff in the pull request:
https://github.com/apache/thrift/pull/688#discussion_r45190854
--- Diff: test/cpp/src/TestClient.cpp ---
@@ -488,7 +488,7 @@ int main(int argc, char** argv) {
testClient.testBinary(bin_result, string(bin_data, 256));
if (bin_result.size() != 256) {
printf("}\n*** FAILED ***\n");
- printf("invalid length: %lu\n", bin_result.size());
+ printf("invalid length: %zu\n", bin_result.size());
--- End diff --
Yeah +1, we could get rid of the printf's all together...
The boost format is cool, but I thought we're looking into getting rid of
it too? hehe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
