Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/688#discussion_r45195544
--- Diff: test/cpp/src/TestClient.cpp ---
@@ -488,7 +488,7 @@ int main(int argc, char** argv) {
testClient.testBinary(bin_result, string(bin_data, 256));
if (bin_result.size() != 256) {
printf("}\n*** FAILED ***\n");
- printf("invalid length: %lu\n", bin_result.size());
+ printf("invalid length: %zu\n", bin_result.size());
--- End diff --
Why constructing such complicated boost format line, when simple `cout <<`
is enough? :) simpler code == better code
Also - it is true - long term development should remove boost, especially
from compiler, to allow maximum ease of thrift portability for 'non-C++' users
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
