[
https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021728#comment-15021728
]
ASF GitHub Bot commented on THRIFT-3437:
----------------------------------------
Github user becrux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/628#discussion_r45579517
--- Diff: lib/cpp/test/OpenSSLManualInitTest.cpp ---
@@ -67,6 +67,22 @@ void test_openssl_availability() {
openssl_cleanup();
}
--- End diff --
Frankly speaking, I'm not a Boost.Test expert. I had to Google a lot to
find a way that could build and run tests successfully. Please apply any change
that could clean the test code, and make it work in any case. My patch could
not be the correct way to fix it (even if I can ensure you that it works fine,
and all tests are passed).
> Mingw-w64 build fail
> --------------------
>
> Key: THRIFT-3437
> URL: https://issues.apache.org/jira/browse/THRIFT-3437
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Affects Versions: 0.9.3
> Environment: Windows XP/7/8/10
> Reporter: Antonio Di Monaco
> Labels: patch
>
> When building Thrift code under MinGW-w64, I got a compilation failure, due
> to the following problems:
> - Missing ws2_32 library link in CMakeLists.txt file
> - conflict with boost/tr1/functional.hpp, when using BOOST_THREAD
> - AI_ADDRCONFIG missing when Win32 version lower than 0x0600
> - Missing __MINGW32__ define
> Tests fail due to getsockname due to:
> - different Win32 getsockname behavior
> - BOOST_TEST_DYN_LINK not supported
> - Q_MOC_RUN / Boost conflict during build
> - mkstemp not supported (cause _mktemp_s should be used)
> Solved with pull request "Fixed MinGW-w64 build && boost/functional conflict
> #628"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
