[
https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081470#comment-15081470
]
ASF GitHub Bot commented on THRIFT-3437:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/628#issuecomment-168750912
@becrux Thanks for that !
You can push your changes to the original branch of this pull request (in
your case it seems master branch of your fork) and the changes will be
immediately visible here.
If you have conflict or something, `git push -f `... should do.
> Mingw-w64 build fail
> --------------------
>
> Key: THRIFT-3437
> URL: https://issues.apache.org/jira/browse/THRIFT-3437
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Affects Versions: 0.9.3
> Environment: Windows XP/7/8/10
> Reporter: Antonio Di Monaco
> Labels: patch
>
> When building Thrift code under MinGW-w64, I got a compilation failure, due
> to the following problems:
> - Missing ws2_32 library link in CMakeLists.txt file
> - conflict with boost/tr1/functional.hpp, when using BOOST_THREAD
> - AI_ADDRCONFIG missing when Win32 version lower than 0x0600
> - Missing __MINGW32__ define
> Tests fail due to getsockname due to:
> - different Win32 getsockname behavior
> - BOOST_TEST_DYN_LINK not supported
> - Q_MOC_RUN / Boost conflict during build
> - mkstemp not supported (cause _mktemp_s should be used)
> Solved with pull request "Fixed MinGW-w64 build && boost/functional conflict
> #628"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
