[ https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037949#comment-15037949 ]
ASF GitHub Bot commented on THRIFT-1840: ---------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/707 > Thrift Generated Code Causes Global Variable Leaks > -------------------------------------------------- > > Key: THRIFT-1840 > URL: https://issues.apache.org/jira/browse/THRIFT-1840 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler > Affects Versions: 0.9 > Reporter: Russell Bradberry > Labels: javascript, node > Attachments: 0001-THRIFT-1840-fix-for-global-variable-leak.patch, > fix_globals.js > > > When compiling for NodeJS, the compiler creates globally scoped variables > which is considered a bad practice as it can create unintended consequences. > It also causes many testing frameworks to fail. > the output looks something like this: > {code} > User = module.exports.User = function(args) { > {code} > when it should be > {code} > var User = module.exports.User = function(args) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)