[ https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038133#comment-15038133 ]
Hudson commented on THRIFT-1840: -------------------------------- SUCCESS: Integrated in Thrift #1755 (See [https://builds.apache.org/job/Thrift/1755/]) THRIFT-1840 Thrift Generated Code Causes Global Variable Leaksk Client: (nsuke: rev 70e6c29e3a0cce7e40a23c6646147ce312e7ab24) * compiler/cpp/src/generate/t_js_generator.cc > Thrift Generated Code Causes Global Variable Leaks > -------------------------------------------------- > > Key: THRIFT-1840 > URL: https://issues.apache.org/jira/browse/THRIFT-1840 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler > Affects Versions: 0.9 > Reporter: Russell Bradberry > Labels: javascript, node > Fix For: 1.0 > > Attachments: 0001-THRIFT-1840-fix-for-global-variable-leak.patch, > fix_globals.js > > > When compiling for NodeJS, the compiler creates globally scoped variables > which is considered a bad practice as it can create unintended consequences. > It also causes many testing frameworks to fail. > the output looks something like this: > {code} > User = module.exports.User = function(args) { > {code} > when it should be > {code} > var User = module.exports.User = function(args) { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)