[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049363#comment-15049363 ]
Roger Meier commented on THRIFT-1805: ------------------------------------- [~elserj], you are right. It is up to you to show interest and contribute on the Java part of Thrift. There are not that many patches and improvement coming in for Java nowadays. Managing every api change within PMC is not ideal as we do not have enough Java stakeholders there. We need to discuss these topics within Jira or the dev mailing list to get some more Java people involved. There are many other projects out there using Thrift without the Apache sister projects and they use other languages such as go, nodejs, c++. I would really like to have more involvement of Apache sister projects and I guess most of them depend on Java and they should integrate very smooth. > Thrift should not swallow ALL exceptions > ---------------------------------------- > > Key: THRIFT-1805 > URL: https://issues.apache.org/jira/browse/THRIFT-1805 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library > Affects Versions: 0.9 > Reporter: Diwaker Gupta > Assignee: Diwaker Gupta > Attachments: THRIFT-1805.patch > > > In Thrift 0.8.0, Thrift generated Java code did not swallow application > exceptions. As a result of THRIFT-1658, this behavior changed in 0.9.0 and > now the generated code swallows ALL application exceptions (via > ProcessFunction). Apparently this was the behavior in Thrift 0.6.0 and while > I see the rationale, it is breaking our applications. > Our code relies on the fact that exceptions can propagate outside of Thrift > for certain things (e.g., to aggressively drop connections for clients that > send invalid/malformed requests). ProcessFunction makes it near impossible to > do this -- not only does it swallow the exception, it also loses all > information about the original exception and just writes out a generic > TApplicationException. > IMO ProcessFunction should only catch TException. If the application code > wants to use other exceptions for some reason (in particular, Errors and > RuntimeExceptions), Thrift shouldn't prevent that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)