[
https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143431#comment-15143431
]
Jens Geyer commented on THRIFT-1805:
------------------------------------
{quote}
It seems that other languages including C++, Go, C#, Node.js, Ruby and Haskell
catche all errors and send exceptions back to the client.
{quote}
There has been some discussion around this but in my humble personal opinion
this should be the default. I don't want anybody to crash my server or to
hard-drop the connection just because some edge case in some arbitrary routine
is not properly handled (which in real life happens) and throws.
I also can't see the value in being required otherwise to add that very same
code to every single interface method implementation by hand if I don't want
the default crashy behaviour. That's why I use a framework and a code generator
in the first place, isn't it? And as it turned out, some other people seem to
have the same view of things.
> Thrift should not swallow ALL exceptions
> ----------------------------------------
>
> Key: THRIFT-1805
> URL: https://issues.apache.org/jira/browse/THRIFT-1805
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler, Java - Library
> Affects Versions: 0.9
> Reporter: Diwaker Gupta
> Assignee: Diwaker Gupta
> Attachments: THRIFT-1805.patch
>
>
> In Thrift 0.8.0, Thrift generated Java code did not swallow application
> exceptions. As a result of THRIFT-1658, this behavior changed in 0.9.0 and
> now the generated code swallows ALL application exceptions (via
> ProcessFunction). Apparently this was the behavior in Thrift 0.6.0 and while
> I see the rationale, it is breaking our applications.
> Our code relies on the fact that exceptions can propagate outside of Thrift
> for certain things (e.g., to aggressively drop connections for clients that
> send invalid/malformed requests). ProcessFunction makes it near impossible to
> do this -- not only does it swallow the exception, it also loses all
> information about the original exception and just writes out a generic
> TApplicationException.
> IMO ProcessFunction should only catch TException. If the application code
> wants to use other exceptions for some reason (in particular, Errors and
> RuntimeExceptions), Thrift shouldn't prevent that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
