[
https://issues.apache.org/jira/browse/THRIFT-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051273#comment-15051273
]
ASF GitHub Bot commented on THRIFT-3484:
----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/738
> Consolidate temporary buffers in Java's TCompactProtocol
> --------------------------------------------------------
>
> Key: THRIFT-3484
> URL: https://issues.apache.org/jira/browse/THRIFT-3484
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Reporter: Tom Lee
> Priority: Minor
>
> TCompactProtocol allocates a number of small temporary buffers per-instance
> and, in some cases e.g. readDouble(), per-method-call. It's fairly trivial to
> consolidate these & save maybe 32 bytes of overhead per TCompactProtocol
> instance and possibly a bunch more for structs that contain lots of doubles.
> Seems like we can also avoid allocating empty ByteBuffers + byte[]s in
> readBinary() by returning singletons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
