[
https://issues.apache.org/jira/browse/THRIFT-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051345#comment-15051345
]
Hudson commented on THRIFT-3484:
--------------------------------
SUCCESS: Integrated in Thrift #1764 (See
[https://builds.apache.org/job/Thrift/1764/])
THRIFT-3484 Consolidate temporary buffers in Java's TCompactProtocol (nsuke:
rev 4f6138b7a2762f1937b49389f72b348736973e22)
* lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java
> Consolidate temporary buffers in Java's TCompactProtocol
> --------------------------------------------------------
>
> Key: THRIFT-3484
> URL: https://issues.apache.org/jira/browse/THRIFT-3484
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Reporter: Tom Lee
> Priority: Minor
> Fix For: 1.0
>
>
> TCompactProtocol allocates a number of small temporary buffers per-instance
> and, in some cases e.g. readDouble(), per-method-call. It's fairly trivial to
> consolidate these & save maybe 32 bytes of overhead per TCompactProtocol
> instance and possibly a bunch more for structs that contain lots of doubles.
> Seems like we can also avoid allocating empty ByteBuffers + byte[]s in
> readBinary() by returning singletons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
