[
https://issues.apache.org/jira/browse/THRIFT-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105641#comment-15105641
]
ASF GitHub Bot commented on THRIFT-3566:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/804#issuecomment-172620051
@szenker thanks for the patches.
Please close this one and #802 as they are merged.
> C++/Qt: TQTcpServerTest::test_communicate() is never executed
> -------------------------------------------------------------
>
> Key: THRIFT-3566
> URL: https://issues.apache.org/jira/browse/THRIFT-3566
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.9.4, 1.0
> Reporter: Sebastian Zenker
> Priority: Minor
>
> The unit test is broken/never executed because of the following three reasons:
> 1. TQTcpServerTest::test_communicate() needs to be declared as Qt slot,
> otherwise the QTest-framework would never execute it. This explains why the
> unit test always succeeded :-)
> 2. The server and synchronous client cannot be executed in the same thread,
> as the server requires the mainloop to run
> 3. The expected response from the server is "foo, bar" and not "foo, foo".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
