[ https://issues.apache.org/jira/browse/THRIFT-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106925#comment-15106925 ]
ASF GitHub Bot commented on THRIFT-3566: ---------------------------------------- Github user szenker closed the pull request at: https://github.com/apache/thrift/pull/804 > C++/Qt: TQTcpServerTest::test_communicate() is never executed > ------------------------------------------------------------- > > Key: THRIFT-3566 > URL: https://issues.apache.org/jira/browse/THRIFT-3566 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9.3, 0.9.4, 1.0 > Reporter: Sebastian Zenker > Priority: Minor > Fix For: 0.9.4 > > > The unit test is broken/never executed because of the following three reasons: > 1. TQTcpServerTest::test_communicate() needs to be declared as Qt slot, > otherwise the QTest-framework would never execute it. This explains why the > unit test always succeeded :-) > 2. The server and synchronous client cannot be executed in the same thread, > as the server requires the mainloop to run > 3. The expected response from the server is "foo, bar" and not "foo, foo". -- This message was sent by Atlassian JIRA (v6.3.4#6332)