[
https://issues.apache.org/jira/browse/THRIFT-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124249#comment-15124249
]
ASF GitHub Bot commented on THRIFT-3589:
----------------------------------------
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/825
THRIFT-3589 Pass references to field names in constructor through
get_field_name
Currently we are incorrectly handling fields that have default values and
uppercase names, like `ID = -1`
@stevenosborne-wf
@ericklaus-wf
@tylertreat-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-3589
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/825.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #825
----
commit b490c74bea0243d027562f32cdb08f972bc99a50
Author: Mark Erickson <mark.erick...@workiva.com>
Date: 2016-01-29T21:25:57Z
Pass references to field names in constructor through get_field_name
----
> Dart generator uses wrong name in constructor for uppercase arguments with
> defaults
> -----------------------------------------------------------------------------------
>
> Key: THRIFT-3589
> URL: https://issues.apache.org/jira/browse/THRIFT-3589
> Project: Thrift
> Issue Type: Bug
> Components: Dart - Compiler
> Reporter: Mark Erickson
> Assignee: Mark Erickson
> Fix For: 0.9.4
>
>
> PROBLEM
> The dart generator produces inconsistent code for argument names that start
> with an uppercase letter and have a default value. The function signature
> uses lowercase, but the constructor uses uppercase.
> SOLUTION
> Pass the argument name through the get_field_name() function, to generate
> code consistent with the other references of argument names.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
