[ 
https://issues.apache.org/jira/browse/THRIFT-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124271#comment-15124271
 ] 

ASF GitHub Bot commented on THRIFT-3589:
----------------------------------------

Github user stevenosborne-wf commented on the pull request:

    https://github.com/apache/thrift/pull/825#issuecomment-176984437
  
    +1


> Dart generator uses wrong name in constructor for uppercase arguments with 
> defaults
> -----------------------------------------------------------------------------------
>
>                 Key: THRIFT-3589
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3589
>             Project: Thrift
>          Issue Type: Bug
>          Components: Dart - Compiler
>            Reporter: Mark Erickson
>            Assignee: Mark Erickson
>             Fix For: 0.9.4
>
>
> PROBLEM
> The dart generator produces inconsistent code for argument names that start 
> with an uppercase letter and have a default value.  The function signature 
> uses lowercase, but the constructor uses uppercase.
> SOLUTION
> Pass the argument name through the get_field_name() function, to generate 
> code consistent with the other references of argument names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to