On Wed, Feb 3, 2016 at 5:33 PM, John Sirois <jsir...@apache.org> wrote:
> In the course of working on a new feature for thrift java, I rebased > against master and hit a test hang runing `make check`. I tracked this > down and have a fix out [1], but I was curious how this hang slipped by. I > happen to have jenkins rights through Apache Aurora to view the job > configuration for Thrift-all and I found it runs: > where [1] is: [1] https://issues.apache.org/jira/browse/THRIFT-3597 > > $ curl --netrc -sS https://builds.apache.org/job/Thrift-all/config.xml | > xmllint --xpath "//command/text()" - > #sh bootstrap.sh > #sloccount --duplicates --wide --details lib tutorial test > > sloccount.sc > #cppcheck --error-exitcode=0 --force --xml lib/cpp/src/ lib/c_glib/src/ > tutorial/cpp/ test/cpp/ 2> cppcheck-result.xml > sh bootstrap.sh > sh configure > make > make dist > cd lib/java > ant javadoc > > So `make` and `make dist`, but no `make check`. > > I'd like to propose adding make check to this set of commands to ensure > make check is green. > > If folks agree this is a good idea, I can go ahead and make the edit. > > Thanks for your feedback. > > >
