[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145025#comment-15145025 ]
John Sirois commented on THRIFT-3112: ------------------------------------- The PROPOSAL thread has had 1 positive response from [~nsuke] and no other responses. The PR @ https://github.com/apache/thrift/pull/840 is now green after re-basing against master to pick up fixes for THRIFT-3608 and THRIFT-3616 and ready for review and merging. > [Java] AsyncMethodCallback should be typed in generated AsyncIface > ------------------------------------------------------------------ > > Key: THRIFT-3112 > URL: https://issues.apache.org/jira/browse/THRIFT-3112 > Project: Thrift > Issue Type: Improvement > Components: Java - Compiler, Java - Library > Affects Versions: 0.9.2 > Reporter: Sergei Egorov > Assignee: John Sirois > > AsyncMethodCallback is generic, but current Java code generator is not adding > type info to it, and instead of: > {code:java} > public interface AsyncIface { > public void ping(org.apache.thrift.async.AsyncMethodCallback<String> > resultHandler) throws org.apache.thrift.TException; > } > {code} > we have: > {code:java} > public interface AsyncIface { > public void ping(org.apache.thrift.async.AsyncMethodCallback > resultHandler) throws org.apache.thrift.TException; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)