[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153429#comment-15153429 ]
ASF GitHub Bot commented on THRIFT-3112: ---------------------------------------- Github user jsirois commented on a diff in the pull request: https://github.com/apache/thrift/pull/840#discussion_r53405834 --- Diff: lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java --- @@ -225,8 +231,13 @@ private void cleanUpAndFireCallback(SelectionKey key) { key.interestOps(0); // this ensures that the TAsyncMethod instance doesn't hang around key.attach(null); --- End diff -- NB: I still don;t fully understand this code, but you've got me reading it more closely. I'll report back when I fully grok what's going on here in the pre-existing code. > [Java] AsyncMethodCallback should be typed in generated AsyncIface > ------------------------------------------------------------------ > > Key: THRIFT-3112 > URL: https://issues.apache.org/jira/browse/THRIFT-3112 > Project: Thrift > Issue Type: Improvement > Components: Java - Compiler, Java - Library > Affects Versions: 0.9.2 > Reporter: Sergei Egorov > Assignee: John Sirois > > AsyncMethodCallback is generic, but current Java code generator is not adding > type info to it, and instead of: > {code:java} > public interface AsyncIface { > public void ping(org.apache.thrift.async.AsyncMethodCallback<String> > resultHandler) throws org.apache.thrift.TException; > } > {code} > we have: > {code:java} > public interface AsyncIface { > public void ping(org.apache.thrift.async.AsyncMethodCallback > resultHandler) throws org.apache.thrift.TException; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)