Github user jsirois commented on the pull request:

    https://github.com/apache/thrift/pull/448#issuecomment-183458933
  
    My 2 nonbinding cents: No reasonable client should care about hashCode 
values, only that the values meet the hashCode contract (this is true of any 
language).  I don't think preserving them should ever be a goal.
    
    A second comment, not as helpful since it requires work, is that we should 
enshrine perf improvements using a tool like 
[jmh](http://openjdk.java.net/projects/code-tools/jmh/).  We use this in 
[Apache 
Aurora](https://github.com/apache/aurora/tree/master/src/jmh/java/org/apache/aurora/benchmark)
 for example to ensure we have a shared history of performance improvements and 
regressions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to