Github user roshan commented on the pull request:
https://github.com/apache/thrift/pull/448#issuecomment-183605715
@nsuke, I switched it so we now consider a `long` like two `int`s (the high
bits and low bits) and we combine their values like we combine `hashCodes`
(just with a different multiplicative factor). For `double`s we get the `long`
represented by their bytes and treat as before. Since we're changing the
values, I also took the chance to pick arbitrary constants to combine with.
For what it's worth, though, the previous `hashCode` helper functions are
pretty much what are described in Effective Java. Anyway, I'll rebase and
squash after you have a look.
@jsirois That's a good idea. Unfortunately, I don't have the time at the
moment to do that :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
