[
https://issues.apache.org/jira/browse/THRIFT-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146587#comment-15146587
]
ASF GitHub Bot commented on THRIFT-3609:
----------------------------------------
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/869
THRIFT-3609 Remove or replace TestPortFixture.h.
Removed since it is no longer used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3609
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #869
----
commit a38dcf2c954ddbe676ca62e5a2194e79436ce784
Author: John Sirois <[email protected]>
Date: 2016-02-14T14:38:30Z
THRIFT-3609 Remove or replace TestPortFixture.h.
Removed since it is no longer used.
----
> Remove or replace TestPortFixture.h
> -----------------------------------
>
> Key: THRIFT-3609
> URL: https://issues.apache.org/jira/browse/THRIFT-3609
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library, Test Suite
> Reporter: John Sirois
> Assignee: John Sirois
>
> Today 6 cpp lib tests use
> [TestPortFixture.h|https://github.com/apache/thrift/blob/1f6e380c5d07686e4cd8c2b172300a1ba7fbd8b9/lib/cpp/test/TestPortFixture.h].
> THRIFT-3608 experimented with correcting one of these cases in
> {{lib/cpp/test/SecurityTest.cpp}}, but a general cleanup should remove all
> uses of static ports in the cpp tests to improve robustness and open the path
> to parallel testing - at least in the cpp libs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
